[Mesa-dev] [PATCH 3/3] i965/fs: Don't consider the stencil output to be a color output.

Kenneth Graunke kenneth at whitecape.org
Wed Aug 24 05:26:20 UTC 2016


On Monday, August 22, 2016 6:59:45 PM PDT Francisco Jerez wrote:
> This would cause gl_FragStencilRef to be counted as a color output
> incorrectly during the precompile phase, which leads to unnecessary
> recompilation on master and could trigger an assertion failure in
> fs_visitor::emit_fb_writes() on my i965-fb-fetch branch.
> ---
>  src/mesa/drivers/dri/i965/brw_wm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c
> index 7b1b839..d725a16 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm.c
> @@ -608,7 +608,8 @@ brw_fs_precompile(struct gl_context *ctx,
>  
>     key.nr_color_regions = _mesa_bitcount_64(fp->Base.OutputsWritten &
>           ~(BITFIELD64_BIT(FRAG_RESULT_DEPTH) |
> -         BITFIELD64_BIT(FRAG_RESULT_SAMPLE_MASK)));
> +           BITFIELD64_BIT(FRAG_RESULT_STENCIL) |
> +           BITFIELD64_BIT(FRAG_RESULT_SAMPLE_MASK)));
>  
>     key.program_string_id = bfp->id;
>  
> 

Patch 3 is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160823/233213b2/attachment.sig>


More information about the mesa-dev mailing list