[Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

Christian König deathsimple at vodafone.de
Wed Aug 24 08:37:35 UTC 2016


Am 22.08.2016 um 22:59 schrieb Eric Engestrom:
> On Mon, Aug 22, 2016 at 09:44:59AM +0200, Christian König wrote:
>> Am 21.08.2016 um 23:11 schrieb Eric Engestrom:
>>> Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync surface")
>>> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
>> Do you have commit access?
> I do not. Feel free to push this and any of my other patches :)
>
> Note to self: I need to go through my outstanding patches and
> ping people to review/push them...

Thought so. Just pushed this one.

Feel free to ping me or others if you still have open patches not 
comitted yet.

Thanks for the help,
Christian.

>
> Cheers,
>    Eric
>
>> Regards,
>> Christian.
>>
>>> ---
>>>    src/gallium/state_trackers/va/surface.c | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c
>>> index 012e48e..3ee1cdd 100644
>>> --- a/src/gallium/state_trackers/va/surface.c
>>> +++ b/src/gallium/state_trackers/va/surface.c
>>> @@ -106,8 +106,10 @@ vlVaSyncSurface(VADriverContextP ctx, VASurfaceID render_target)
>>>       pipe_mutex_lock(drv->mutex);
>>>       surf = handle_table_get(drv->htab, render_target);
>>> -   if (!surf || !surf->buffer)
>>> +   if (!surf || !surf->buffer) {
>>> +      pipe_mutex_unlock(drv->mutex);
>>>          return VA_STATUS_ERROR_INVALID_SURFACE;
>>> +   }
>>>       context = handle_table_get(drv->htab, surf->ctx);
>>>       if (!context) {
>>



More information about the mesa-dev mailing list