[Mesa-dev] [PATCH mesa] glx/dri3: remove never-used field

Emil Velikov emil.l.velikov at gmail.com
Wed Aug 24 10:22:59 UTC 2016


On 2 August 2016 at 17:22, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> This field was added in 2d94601582e4f0fcaf8c ("Add DRI3+Present loader"), which
> was a v2. Guessing it was used in v1 and Keith forgot to remove it in v2.
>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>
> Fair warning: This patch will conflict with Jan Ziak's "[PATCH] dri: use 'bool'
> instead of 'int' for boolean variables", depending on which is applied first.
> Whoever picks one should pick the other and deal with the conflict right way :)
>
> ---
>
>  src/glx/dri3_priv.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/glx/dri3_priv.h b/src/glx/dri3_priv.h
> index 0822377..31b2b98 100644
> --- a/src/glx/dri3_priv.h
> +++ b/src/glx/dri3_priv.h
> @@ -78,7 +78,6 @@ struct dri3_display
>     int dri3Minor;
>
>     /* Present bits */
> -   int hasPresent;
>     int presentMajor;
>     int presentMinor;
The variable is never set actually. The other two (and maybe others)
are set-but-unused.

Can you do a quick grep through the struct and purge all the unused
variables in one go ?

Thanks
Emil


More information about the mesa-dev mailing list