[Mesa-dev] [PATCH 00/17] Enable

Ilia Mirkin imirkin at alum.mit.edu
Wed Aug 24 23:03:21 UTC 2016


Patches 1-16 are

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I left a few comments on a handful, but other than the one you've
already addressed, none are particularly important.

You'll have to sucker someone else into looking at patch 17, I'm afraid.

On Wed, Aug 24, 2016 at 6:12 PM, Ian Romanick <idr at freedesktop.org> wrote:
> This series enables GL_OES_geometry_shader and
> GL_OES_texutre_cube_map_array.  There are still a number of failures
> with this series, but I would like to land it anyway so that I don't
> have to keep rebasing it.  Here is my analysis of the failures:
>
> ES3-CTS.gtf.GL3Tests.texture_storage.texture_storage_texture_targets
>
>     This is a fake failure.  The OpenGL ES 3.0 CTS test does not know
>     about GL_OES_texture_cube_map_array, so it expects the texture
>     target to fail even when the extension exists.
>
>     On platforms where we run GLES 3.1 conformance, we shouldn't run
>     GLES 3.0 conformance too.  It's redundant, and, apparently, buggy.
>
> glsl-es-3_10/built-in constants
> oes_geometry_shader/built-in constants
>
>     Bug in built-in-constants.c.  Patch on the piglit list.
>
> ES31-CTS.geometry_shader.program_resource.program_resource
>
>     The test is checking GL_REFERENCED_BY_GEOMETRY_SHADER_EXT for
>     several variables of different kinds in the geometry shader.
>     Somewhere along the lines, we get our wires crossed, and the fields
>     are not set correct.  This is going to take a bit of effort to fix,
>     and it is not releated to the functionality enabled by this
>     extension.
>
> This series is also on the oes_geometry_shader branch of my fd.o tree.
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list