[Mesa-dev] [PATCH 00/16] Enable OpenGLES 3.1 on Haswell

Pohjolainen, Topi topi.pohjolainen at gmail.com
Thu Aug 25 05:54:20 UTC 2016


On Wed, Aug 24, 2016 at 05:51:22PM -0700, Ian Romanick wrote:
> On 08/24/2016 04:54 PM, Jordan Justen wrote:
> > git://people.freedesktop.org/~jljusten/mesa hsw-es31-v1
> > 
> > Since gen7 doesn't support sampling from a stencil buffer, we copy the
> > stencil texture to an R8_UINT texture, and sample from it instead.
> > 
> > This allows us to enable ARB_stencil_texturing and OpenGLES 3.1 on
> > Haswell.
> > 
> > Ivy Bridge and Baytrail require additional (in progress) work to fix
> > some integer border color sampling issues.
> 
> Once the IVB and BYT work lands, I'll send patches to enable the other
> GL_OES_shader_io_blocks and GL_OES_geometry_shader on those platforms.
> 
> I sent a couple minor nits on 4, 10, and 12.  With or without those
> changes, the series is
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> It would still be good for someone who actually understands (ha!) the
> miptree code to review too.

Well, at least another pair of eyes, 6-10 are also:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

I'm happy to see how simple this became in the end. Nice work Jordan!

> 
> > Jordan Justen (16):
> >   main: Add MESA_VERBOSE=api support for glTexImage
> >   main: Add MESA_VERBOSE=api support for glClearStencil
> >   i965/hsw: Don't advertise more than 64 threads for compute shaders
> >   i965/hsw: Adjust uploading default color for stencil surfaces
> >   i965: Fix assert with multisampling and cubemaps
> >   i965/gen7: Add R8_UINT stencil miptree copy for sampling
> >   i965: Track that the stencil data was updated when clearing
> >   i965: Track that the stencil data was updated when rendering
> >   i965: Track that the stencil data was updated when using Tex*Image
> >   i965: Add function to copy a stencil miptree to an R8_UINT miptree
> >   i965/gen7: Copy stencil when sampling the stencil texture
> >   i965/gen7: Use R8_UINT stencil copy when sampling the stencil texture
> >   i965: Enable ARB_stencil_texturing for Haswell
> >   i965: Enable ARB_texture_stencil8 for Haswell
> >   i965: Enable OpenGLES 3.1 for Haswell
> >   docs: Update stencil texturing & ES 3.1 status for i965 Haswell
> > 
> >  docs/GL3.txt                                     |  6 +--
> >  docs/relnotes/12.1.0.html                        |  3 ++
> >  src/mesa/drivers/dri/i965/brw_clear.c            |  8 +++
> >  src/mesa/drivers/dri/i965/brw_context.c          | 44 +++++++++++------
> >  src/mesa/drivers/dri/i965/brw_sampler_state.c    |  8 ++-
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 ++++-
> >  src/mesa/drivers/dri/i965/gen7_misc_state.c      |  1 +
> >  src/mesa/drivers/dri/i965/intel_extensions.c     |  7 ++-
> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c    | 63 ++++++++++++++++++++++--
> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.h    | 16 ++++++
> >  src/mesa/drivers/dri/i965/intel_screen.c         |  5 ++
> >  src/mesa/drivers/dri/i965/intel_tex_image.c      |  3 ++
> >  src/mesa/drivers/dri/i965/intel_tex_subimage.c   |  7 ++-
> >  src/mesa/main/stencil.c                          |  3 ++
> >  src/mesa/main/teximage.c                         |  5 ++
> >  15 files changed, 164 insertions(+), 28 deletions(-)
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list