[Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

[Weng, Chuanbo]

Hi Dave,
	I've sent out v2 patch based on your comments. Could you please review it? Thanks!

-----Original Message-----
From: Weng, Chuanbo 
Sent: Friday, August 19, 2016 4:15 PM
To: 'Dave Airlie' <airlied at gmail.com>
Cc: Eric Engestrom <eric.engestrom at imgtec.com>; airlied at redhat.com; emil.l.velikov at gmail.com; mesa-dev at lists.freedesktop.org
Subject: RE: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

I think I have understood what you mean. Thanks!
I will send out patch v2 based on your suggestion later. 
Please help to review it. Thanks.

-----Original Message-----
From: Dave Airlie [mailto:airlied at gmail.com]
Sent: Friday, August 19, 2016 3:31 PM
To: Weng, Chuanbo <chuanbo.weng at intel.com>
Cc: Eric Engestrom <eric.engestrom at imgtec.com>; airlied at redhat.com; emil.l.velikov at gmail.com; mesa-dev at lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

On 19 August 2016 at 17:24, Weng, Chuanbo <chuanbo.weng at intel.com> wrote:
> Thanks Dave for your suggestion!
> I'll refine the patch. One question: Is there any standard process to 
> bump version on this extension, or I just need to add something to docs/specs/MESA_image_dma_buf_export.txt ?

You don't need to change the extension I don't think.

You just need to change the EGL/driver interface in mesa.

Dave.

>
> -----Original Message-----
> From: Dave Airlie [mailto:airlied at gmail.com]
> Sent: Friday, August 19, 2016 9:47 AM
> To: Weng, Chuanbo <chuanbo.weng at intel.com>
> Cc: Eric Engestrom <eric.engestrom at imgtec.com>; airlied at redhat.com; 
> emil.l.velikov at gmail.com; mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.
>
> On 18 August 2016 at 12:59, Weng, Chuanbo <chuanbo.weng at intel.com> wrote:
>> Hi Dave and all,
>>         (Since Dave implemented this extension EGL_MESA_image_dma_buf_export, so I also send this email to you.)
>>         Could you please review this patch and push it if it looks good to you? Thanks!
>
>
> I think this needs a version bump on the EGL image interface.
>
> It will also break the gallium drivers, as it doesn't check the return value of queryImage, and you haven't patched the other drivers to provide the values or set them to 0.
>
> Dave.