[Mesa-dev] [PATCH 08/30] XXX: egl: comment on IsLinked presence/necessity
Emil Velikov
emil.l.velikov at gmail.com
Thu Aug 25 16:18:30 UTC 2016
---
Not meant to be merged, but to inspire dicussion.
---
src/egl/main/egldisplay.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c
index bbc3063..30fb687 100644
--- a/src/egl/main/egldisplay.c
+++ b/src/egl/main/egldisplay.c
@@ -411,6 +411,13 @@ _eglLinkResource(_EGLResource *res, _EGLResourceType type)
{
assert(res->Display);
+ // XXX: KILLME: afaict one should be able to kill this one off, considering
+ // we do refcounting of the resources. Thus _eglIsResourceLinked will become
+ // a no-op and functions based on it will_eglGet<foo>Handle will be simplified
+ // or even nuked since the !ret case is _always_ equal to EGL_NO_<foo> i.e. 0
+ //
+ // See commits dc4f845c37a8446de19036e24fd397a0aa864c02 and
+ // d19afc57fe49816f3f3290410e0124d326577be2.
res->IsLinked = EGL_TRUE;
res->Next = res->Display->ResourceLists[type];
res->Display->ResourceLists[type] = res;
--
2.9.0
More information about the mesa-dev
mailing list