[Mesa-dev] [PATCH 1/3] intel/isl: Use DIM_LAYOUT_GEN4_2D for tiled 1-D surfaces on SKL

[Chad Versace]

On Thu 25 Aug 2016, Pohjolainen, Topi wrote:
> On Tue, Aug 23, 2016 at 09:53:46PM -0700, Jason Ekstrand wrote:
> > The Sky Lake 1D layout is only used if the surface is linear.  For tiled
> > surfaces such as depth and stenil the old gen4 2D layout is used.
> 
>                              stencil
> 
> > 
> > Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> > Cc: Chad Versace <chad at kiwitree.net>
> > ---
> >  src/intel/isl/isl.c | 28 +++++++++++++++++++++++-----
> >  1 file changed, 23 insertions(+), 5 deletions(-)

> > +   enum isl_dim_layout dim_layout =
> 
> There are quite a few of these helper variables in this function. Most of
> them, such as this, are constants. We could start declaring them as such.
> Either way - the logic makes sense to me:
> 
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

+1 for constness.

Either way, patch 1 is
Reviewed-by: Chad Versace <chadversary at chromium.org>