[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

[Kai Wasserbäch]

Hey Brian,
Brian Paul wrote on 26.08.2016 14:50:
> On 08/26/2016 05:58 AM, Kai Wasserbäch wrote:
>> Cc: Brian Paul <brianp at vmware.com>
>> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
>> ---
>>
>> Hi Brian,
>> is this what you had in mind? If so, I was wondering whether virgl_encode.c
>> would need to be updated as well. Doesn't seem like it, since the functions
>> there map everything to uint32_t or some other standard type.
>>
>> Another point are the switch statements nouveau uses. To silence the -Wswitch
>> warning of GCC I stuck a default case with two asserts at the end of them. But
>> maybe it would be better to use an if...else for nv30 and nv50.
> 
> I think one assertion is enough.  It's up to the nouveau developers whether they
> want to do more.

ok, then I'll go for the generic "unhandled type" assert.

>> Cheers,
>> Kai
>>
>> P.S.: If this is the right direction, I can do the remaining stuff as well.
> 
> I think there was another person interested so feel free to share the task.

Eric, I'm sorry I didn't see your message before I had prepared this patch and
sent it. If I should leave the rest alone, just give me a shout. Would be
unfortunate if we did the same task twice.

> BTW, looks like pipe_screen::get_compiler_options() has another unsigned -->
> enum candidate.
> 
> 
>> P.P.S.: If this patch is accepted, please commit it for me, as I do not have
>> commit access.
> 
> Looks good.  Just a few minor comments below.

v2 will arrive shortly.

Thanks for the review,
Kai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160826/357e9e11/attachment.sig>