[Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

[Eric Engestrom]

On Fri, Aug 26, 2016 at 06:50:52AM -0600, Brian Paul wrote:
> On 08/26/2016 05:58 AM, Kai Wasserbäch wrote:
> > Cc: Brian Paul <brianp at vmware.com>
> > Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> > ---
> > 
> > Hi Brian,
> > is this what you had in mind? If so, I was wondering whether virgl_encode.c
> > would need to be updated as well. Doesn't seem like it, since the functions
> > there map everything to uint32_t or some other standard type.
> > 
> > Another point are the switch statements nouveau uses. To silence the -Wswitch
> > warning of GCC I stuck a default case with two asserts at the end of them. But
> > maybe it would be better to use an if...else for nv30 and nv50.
> 
> I think one assertion is enough.  It's up to the nouveau developers whether
> they want to do more.
> 
> 
> > 
> > Cheers,
> > Kai
> > 
> > P.S.: If this is the right direction, I can do the remaining stuff as well.
> 
> I think there was another person interested so feel free to share the task.

Meh, go for it :)