[Mesa-dev] [PATCH] configure.ac: add llvm inteljitevents component if enabled

[Rowley, Timothy O]

> On Aug 26, 2016, at 8:30 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> On 2 August 2016 at 18:54, Tim Rowley <timothy.o.rowley at intel.com> wrote:
>> Needed to successfully link llvmpipe or swr when using shared llvm libs.
>> ---
>> configure.ac | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git a/configure.ac b/configure.ac
>> index fb4a12a..edbc95b 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -2497,6 +2497,11 @@ dnl in LLVM_LIBS.
>> 
>> if test "x$MESA_LLVM" != x0; then
>> 
>> +    if test "x$HAVE_GALLIUM_LLVMPIPE" = xyes || "x$HAVE_GALLIUM_SWR" = xyes && \
>> +            $LLVM_CONFIG --components | grep -q inteljitevents ; then
>> +       LLVM_COMPONENTS="${LLVM_COMPONENTS} inteljitevents"
>> +    fi
>> +
> Hmm is this something required by newer LLVM, I don't recall seeing
> any issues so far. Are you sure it's required for llvmpipe and swr and
> not r600, radeonsi ?

It’s only needed if you have inteljitevents enabled in your llvm build configuration, which is probably somewhat rare as they are hooks for VTune.

> If it's required by everyone please add the hunk just after the
> LLVM_COMPONENTS="engine bitwriter mcjit mcdisassembler, alternatively
> keep it in the specific driver section (see r600/radeonsi).
> In either case there should be a llvm version check imho.

The symbol dependency is created by anyone using gallivm; since this is included in libgallium this means it should be common to all gallium drivers.  I’ll make that change and resend.  IntelJITEvents was built as a separate component back to llvm 3.3, which is the earliest configure.ac allows for gallium, so I don’t think a version check is needed.

> 
> Thanks
> Emil