[Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

Ilia Mirkin imirkin at alum.mit.edu
Mon Aug 29 18:23:19 UTC 2016


On Mon, Aug 29, 2016 at 2:19 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> On Mon, 2016-08-29 at 14:47 +0200, Marek Olšák wrote:
>> On Sun, Aug 28, 2016 at 7:57 PM, Jan Vesely <jan.vesely at rutgers.edu>
>> wrote:
>> >
>> > v2: document the new cap
>> >
>> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> > ---
>> >  src/gallium/docs/source/screen.rst             | 1 +
>> >  src/gallium/drivers/ilo/ilo_screen.c           | 6 ++++++
>> >  src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++
>> >  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++
>> >  src/gallium/drivers/radeon/r600_pipe_common.c  | 8 ++++++++
>> >  src/gallium/drivers/softpipe/sp_screen.c       | 1 +
>> >  src/gallium/include/pipe/p_defines.h           | 1 +
>> >  7 files changed, 21 insertions(+)
>> >
>> > diff --git a/src/gallium/docs/source/screen.rst
>> > b/src/gallium/docs/source/screen.rst
>> > index c00d012..8c67604 100644
>> > --- a/src/gallium/docs/source/screen.rst
>> > +++ b/src/gallium/docs/source/screen.rst
>> > @@ -496,6 +496,7 @@ pipe_screen::get_compute_param.
>> >    non-zero means yes, zero means no. Value type: ``uint32_t``
>> >  * ``PIPE_COMPUTE_CAP_SUBGROUP_SIZE``: The size of a basic
>> > execution unit in
>> >    threads. Also known as wavefront size, warp size or SIMD width.
>> > +* ``PIPE_COMPUTE_CAP_ADDRESS_BITS``: The default compute device
>> > address space size specified as an unsigned integer value in bits.
>>
>> There is the 80 chars per line limit in this file.
>
> I'll fix that locally before pushing.
> @Illia, are you OK with the nouveau bits?

Acked-by: Ilia Mirkin <imirkin at alum.mit.edu>

It's a bit academic for nouveau, as there's no opencl support, but
perhaps hansg will finish that work some day. We can figure out what
the right thing is then, in case it's not what's in your patch today.

  -ilia


More information about the mesa-dev mailing list