[Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

Topi Pohjolainen topi.pohjolainen at gmail.com
Wed Aug 31 16:05:07 UTC 2016


Otherwise once mcs buffer gets allocated without delay for
lossless compression (same as we do for msaa), assert starts
to fire in piglit case: tex3d. The test uses depth of one
which is in fact supported even now.

Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
---
 src/intel/isl/isl.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index c4989dd..b5c4a8c 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -1328,7 +1328,12 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
    assert(surf->samples == 1 && surf->msaa_layout == ISL_MSAA_LAYOUT_NONE);
    assert(ISL_DEV_GEN(dev) >= 7);
 
-   assert(surf->dim == ISL_SURF_DIM_2D);
+   if (ISL_DEV_GEN(dev) < 8) {
+      assert(surf->dim == ISL_SURF_DIM_2D);
+   } else {
+      assert(surf->dim == ISL_SURF_DIM_2D || surf->dim == ISL_SURF_DIM_3D);
+   }
+
    assert(surf->logical_level0_px.depth == 1);
 
    /* TODO: More conditions where it can fail. */
-- 
2.5.5



More information about the mesa-dev mailing list