[Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

Eric Engestrom eric.engestrom at imgtec.com
Fri Dec 2 17:56:21 UTC 2016


On Thursday, 2016-12-01 14:09:43 -0800, Ben Widawsky wrote:
> From: Ben Widawsky <ben at bwidawsk.net>
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> ---
>  src/gbm/main/gbm.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h
> index 59daaa1..efb329e 100644
> --- a/src/gbm/main/gbm.h
> +++ b/src/gbm/main/gbm.h
> @@ -294,10 +294,10 @@ gbm_bo_map(struct gbm_bo *bo,
>  void
>  gbm_bo_unmap(struct gbm_bo *bo, void *map_data);
>  
> -uint32_t
> +unsigned int
>  gbm_bo_get_width(struct gbm_bo *bo);
>  
> -uint32_t
> +unsigned int
>  gbm_bo_get_height(struct gbm_bo *bo);

I'm not sure I understand this change. Why would you want to remove the
information of the type size? If the point is to increase it on 64-bit
machines, I'd go with an explicit `uint64_t` instead.

>  
>  uint32_t
> -- 
> 2.10.2
> 


More information about the mesa-dev mailing list