[Mesa-dev] [PATCH 02/27] gbm: Fix width height getters return type (trivial)

[Daniel Stone]

Hi Ben,

On 2 December 2016 at 18:17, Ben Widawsky <ben at bwidawsk.net> wrote:
> On 16-12-02 18:07:22, Daniel Stone wrote:
>> On 2 December 2016 at 17:56, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>> I have to admit I didn't catch this one. It doesn't help on 64-bit
>> since unsigned int is still 32-bit there, and in any case it's library
>> ABI, so if it doesn't change anything then it doesn't help, and if it
>> does then it's an ABI break, so NAK from me.
>
> It was like the patch says, meant to match the definition of the
> implementation.
> The exported symbol is defined as unsigned int. It had nothing to do with
> 64-bit.
>
> GBM_EXPORT unsigned int
> gbm_bo_get_height(struct gbm_bo *bo)
>
> I'd say they should match, and both can be uint32_t. I don't care much
> either
> way.

Right. Given that we have multiple implementations of libgbm in the
wild, I'd be much more comfortable saying that the existing gbm.h is
canonical, and changing the Mesa implementation to match.

Cheers,
Daniel