[Mesa-dev] [PATCH] i965: Release aux buffer when disabling ccs

Jason Ekstrand jason at jlekstrand.net
Mon Dec 5 04:36:03 UTC 2016


On Sun, Dec 4, 2016 at 2:08 PM, Topi Pohjolainen <topi.pohjolainen at gmail.com
> wrote:

> Otherwise subsequent render cycles keep on using compression
> and/or fast clear.
>

I believe that's because most things look at mt->mcs_buf rather than
no_ccs.  Given that we're allocating the CCS up-front, is no_ccs really
doing anything for us or can we just use mt->mcs_buf?  Maybe it's mostly
used during miptree setup?


> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> CC: Kalyan Kondapally <kalyan.kondapally at intel.com>
> CC: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index a9b350e..7cda019 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2326,6 +2326,9 @@ intel_miptree_make_shareable(struct brw_context
> *brw,
>     if (mt->mcs_buf) {
>        intel_miptree_all_slices_resolve_color(brw, mt, 0);
>        mt->no_ccs = true;
> +      drm_intel_bo_unreference(mt->mcs_buf->bo);
> +      free(mt->mcs_buf);
> +      mt->mcs_buf = NULL;
>     }
>  }
>
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161204/0cb06876/attachment.html>


More information about the mesa-dev mailing list