[Mesa-dev] [PATCH] docs: document how to (self-) reject stable patches

Nanley Chery nanleychery at gmail.com
Mon Dec 5 18:02:15 UTC 2016


On Mon, Dec 05, 2016 at 04:11:21PM +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Document what has been the unofficial way to self-reject stable patches.
> 
> Namely: drop the mesa-stable tag and push the commit.
> 
> Cc: Nanley Chery <nanley.g.chery at intel.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Nanley, I fear that adding this note to the criteria section will get
> lost.
> 
> Please let me know if you prefer it there and/or if we can make the
> wording clearer and less likely to miss.

Hi Emil,

I agree with your approach. Documenting this note in a manner that
stands out is a good idea. Thank you very much for making this part of
the stable-patch submission process explicit.

This patch is,
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

> ---
>  docs/submittingpatches.html | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index d1ca68d..141cec2 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
> @@ -249,6 +249,13 @@ copied to the mesa-stable@ mailing list when you use "git send-email" to send
>  patches to the mesa-dev@ mailing list. If you prefer using --suppress-cc that
>  won't have any effect negative effect on the patch nomination.
>  
> +<p>
> +Note: by removing the tag [as the commit is pushed] the patch is
> +<strong>explicitly</strong> rejected from inclusion in the stable branch(es).
> +<br>
> +Thus, drop the line <strong>only</strong> if you want to cancel the nomination.
> +</p>
> +
>  <h2 id="criteria">Criteria for accepting patches to the stable branch</h2>
>  
>  Mesa has a designated release manager for each stable branch, and the release
> -- 
> 2.10.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list