[Mesa-dev] [RFC 5/6] i965: Enable ARB_transform_feedback_overflow_query.

[Rafael Antognolli]

On Mon, Dec 05, 2016 at 10:57:16AM -0800, Ian Romanick wrote:
> On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> > Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> > ---
> >  src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> >  src/mesa/main/extensions_table.h             | 1 +
> >  src/mesa/main/get.c                          | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c
> > index 66079b5..ea56220 100644
> > --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> > +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> > @@ -320,6 +320,7 @@ intelInitExtensions(struct gl_context *ctx)
> >        ctx->Extensions.EXT_framebuffer_multisample = true;
> >        ctx->Extensions.EXT_framebuffer_multisample_blit_scaled = true;
> >        ctx->Extensions.EXT_transform_feedback = true;
> > +      ctx->Extensions.ARB_transform_feedback_overflow_query = true;
> >        ctx->Extensions.OES_depth_texture_cube_map = true;
> >        ctx->Extensions.OES_sample_variables = true;
> 
> This would usually be in a patch just modifies code in
> src/mesa/drivers/dri/i965 or a patch by itself.  Also, update
> docs/features.txt and docs/relnotes/.

Ack, will do it.

> >  
> > diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h
> > index d3ec551..8774d14 100644
> > --- a/src/mesa/main/extensions_table.h
> > +++ b/src/mesa/main/extensions_table.h
> > @@ -160,6 +160,7 @@ EXT(ARB_timer_query                         , ARB_timer_query
> >  EXT(ARB_transform_feedback2                 , ARB_transform_feedback2                , GLL, GLC,  x ,  x , 2010)
> >  EXT(ARB_transform_feedback3                 , ARB_transform_feedback3                , GLL, GLC,  x ,  x , 2010)
> >  EXT(ARB_transform_feedback_instanced        , ARB_transform_feedback_instanced       , GLL, GLC,  x ,  x , 2011)
> > +EXT(ARB_transform_feedback_overflow_query   , ARB_transform_feedback_overflow_query  , GLL, GLC,  x ,  x , 2016)
> >  EXT(ARB_transpose_matrix                    , dummy_true                             , GLL,  x ,  x ,  x , 1999)
> >  EXT(ARB_uniform_buffer_object               , ARB_uniform_buffer_object              , GLL, GLC,  x ,  x , 2009)
> >  EXT(ARB_vertex_array_bgra                   , EXT_vertex_array_bgra                  , GLL, GLC,  x ,  x , 2008)
> 
> This change should be added in the same patch that adds
> ARB_transform_feedback_overflow_query in mtypes.h.  See
> https://cgit.freedesktop.org/~idr/mesa/commit/?h=ARB_transform_feedback_overflow_query&id=7eaf174d7a28c52b717a38896c1e782302fcd87f.

OK.

> > diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> > index 5f5e76a..f103018 100644
> > --- a/src/mesa/main/get.c
> > +++ b/src/mesa/main/get.c
> > @@ -455,6 +455,7 @@ EXTRA_EXT(ARB_sync);
> >  EXTRA_EXT(ARB_vertex_shader);
> >  EXTRA_EXT(EXT_transform_feedback);
> >  EXTRA_EXT(ARB_transform_feedback3);
> > +EXTRA_EXT(ARB_transform_feedback_overflow_query);
> >  EXTRA_EXT(EXT_pixel_buffer_object);
> >  EXTRA_EXT(ARB_vertex_program);
> >  EXTRA_EXT2(NV_point_sprite, ARB_point_sprite);
> > 
> 
> Does anything use this?

Hmm... no, I admit I was just copying code from other extensions. It
doesn't look like it's needed for this one. Sorry for this one.

Thanks,
Rafael