[Mesa-dev] [PATCH 1/5] configure: forbid static EGL/GBM

Emil Velikov emil.l.velikov at gmail.com
Wed Dec 7 13:24:57 UTC 2016


From: Emil Velikov <emil.velikov at collabora.com>

Both libraries implicitly require shared GLAPI which in itself mandates
shared libraries.

Stop pretending that one can use it and error out at configure stage.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 configure.ac | 36 ++++++++++++++++++++----------------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/configure.ac b/configure.ac
index adca49d..e25b81c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1970,6 +1970,10 @@ dnl
 dnl gbm configuration
 dnl
 if test "x$enable_gbm" = xyes; then
+    if test "x$enable_static" = xyes; then
+        AC_MSG_ERROR([gbm cannot be build as static library])
+    fi
+
     if test "x$enable_dri" = xyes; then
         if test "x$enable_shared_glapi" = xno; then
             AC_MSG_ERROR([gbm_dri requires --enable-shared-glapi])
@@ -2000,24 +2004,24 @@ if test "x$enable_egl" = xyes; then
 
     AC_CHECK_FUNC(mincore, [DEFINES="$DEFINES -DHAVE_MINCORE"])
 
-    if test "$enable_static" != yes; then
-        if test "x$enable_dri" = xyes; then
-            HAVE_EGL_DRIVER_DRI2=1
+    if test "x$enable_static" = xyes; then
+        AC_MSG_ERROR([egl cannot be build as static library])
+    fi
+
+    if test "x$enable_dri" = xyes; then
+        HAVE_EGL_DRIVER_DRI2=1
+        if test "x$enable_shared_glapi" = xno; then
+            AC_MSG_ERROR([egl_dri2 requires --enable-shared-glapi])
+        fi
+        if test "x$enable_dri3" = xyes; then
+            HAVE_EGL_DRIVER_DRI3=1
             if test "x$enable_shared_glapi" = xno; then
-                AC_MSG_ERROR([egl_dri2 requires --enable-shared-glapi])
-            fi
-            if test "x$enable_dri3" = xyes; then
-                HAVE_EGL_DRIVER_DRI3=1
-                if test "x$enable_shared_glapi" = xno; then
-                    AC_MSG_ERROR([egl_dri3 requires --enable-shared-glapi])
-                fi
-            fi
-        else
-            # Avoid building an "empty" libEGL. Drop/update this
-            # when other backends (haiku?) come along.
-            AC_MSG_ERROR([egl requires --enable-dri])
+            AC_MSG_ERROR([egl_dri3 requires --enable-shared-glapi])
         fi
-
+    else
+        # Avoid building an "empty" libEGL. Drop/update this
+        # when other backends (haiku?) come along.
+        AC_MSG_ERROR([egl requires --enable-dri])
     fi
 fi
 AM_CONDITIONAL(HAVE_EGL, test "x$enable_egl" = xyes)
-- 
2.10.2



More information about the mesa-dev mailing list