[Mesa-dev] [PATCH] automake: make the build less chatty

[Emil Velikov]

On 8 December 2016 at 14:07, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 08.12.2016 12:30, Emil Velikov wrote:
>>
>> On 7 December 2016 at 20:20, Eric Anholt <eric at anholt.net> wrote:
>>>
>>> Emil Velikov <emil.l.velikov at gmail.com> writes:
>>>
>>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>>
>>>> Having the "Entering|Leaving directory X" messages it not required nor
>>>> useful in vast majority of the cases.
>>>>
>>>> One can always have them printed by `make -w' or by overriding the
>>>> AM_MAKEFLAGS variable.
>>>>
>>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>>
>>>
>>> I tried this out today and it breaks my go-to-error macro in emacs.  I
>>> don't see how an IDE could parse the build output any more to implement
>>> it, either.
>>>
>>> I don't think we should land this.
>>
>>
>> Have you tried any of the following
>> $ make -w
>> $ make AM_MAKEFLAGS=
>> or even specify a specific subfolder containing Makefile.am
>> $ make -C .
>> $ make -C src
>>
>> I'm not familiar with emacs, let alone the particular macro, or I
>> would have sent you a patch :-)
>> There are other projects in the wild who use -s, so using the above
>> will make your environment more robust.
>
>
> I'm all for reducing chattiness, but I'm not happy about this change either.
>
> Maybe those other projects ensure that the base directory for warning and
> error messages stays at the project root?
Not entirely sure what you mean here. Can you please elaborate ?

With and w/o the flag the entire warning/error message is the same.
The only different that I can see between autohell and cmake is that
former uses relative paths, while the latter absolute ones.
Skimming through - nothing obvious comes up on convincing autoconf to
generate/use the absolute ones.

Making all in loader
  CC       libloader_la-loader.lo
In file included from ../../../src/loader/loader.c:50:0:
../../../src/mesa/drivers/dri/common/xmlpool.h:103:29: fatal error:
xmlpool/options.h: No such file or directory
 #include "xmlpool/options.h"

Making all in loader
make[3]: Entering directory '/home/emil/development/mesa-13.0/aa/src/loader'
  CC       libloader_la-loader.lo
In file included from ../../../src/loader/loader.c:50:0:
../../../src/mesa/drivers/dri/common/xmlpool.h:103:29: fatal error:
xmlpool/options.h: No such file or directory
 #include "xmlpool/options.h"

> I think that's what the Linux
> kernel makefiles do, as well as cmake makefiles.
>
Funny enough, I came across this as Linus ranting^discussing how
distracting these are ;-)

Thanks
Emil