[Mesa-dev] [PATCH 6/6] configure.ac: Don't check LLVM version in gallium_require_llvm

[Tobias Droste]

Am Donnerstag, 8. Dezember 2016, 17:24:14 CET schrieb Emil Velikov:
> On 8 December 2016 at 02:03, Tobias Droste <tdroste at gmx.de> wrote:
> > This is actually not needed because the version is checked later.
> > 
> > Line 2609:
> > if test "x$enable_gallium_llvm" == "xyes"; then
> > 
> >     llvm_require_version $LLVM_REQUIRED_GALLIUM "gallium"
> >     llvm_add_default_components "gallium"
> >     
> >     HAVE_GALLIUM_LLVM=xyes
> >     DEFINES="${DEFINES} -DHAVE_GALLIUM_LLVM"
> > 
> > fi
> > 
> > Signed-off-by: Tobias Droste <tdroste at gmx.de>
> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> As i was skimming through last night, a couple of related issues come to
> light: - original code (before your work) was buggy and was silently
> dropping LLVM even if one explicitly passed --enable-gallium-llvm
> Now the default heuristic dominates and "forces" people to have LLVM
> or use --disable-gallium-llvm.
> Can we use FOUND_LLVM alongside the "is x86 platform" to determine if
> we should enable gallium-llvm ?
> 
>  - we do not change the "auto" to "no" in the !x86 case.
> 
> Thanks
> Emil

I'm in favor of this and I had this in the original series that reworked the 
llvm stuff.

Your main concern there was that if someone has no llvm installed and builds 
for example just the r300 gallium driver he would get r300 without gallium 
llvm.

As far as I understood this is not what the other developers want.

Tobias