[Mesa-dev] [PATCH 2/3] mesa: main: don't error when enabling conservative rasterization on gles

Ilia Mirkin imirkin at alum.mit.edu
Fri Dec 9 01:31:05 UTC 2016


BTW, the subject prefix thing goes for all your patches. Have a look
at other patches that touched these files for inspiration.

On Thu, Dec 8, 2016 at 8:27 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Usually the subject prefix here would just be "mesa". Sometimes people
> might put "mesa/main". I don't think the "a: b:" thing is frequently
> done in mesa. With that fixed up,
>
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> On Thu, Dec 8, 2016 at 6:00 AM, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>  src/mesa/main/enable.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
>> index 8440c62..2267e31 100644
>> --- a/src/mesa/main/enable.c
>> +++ b/src/mesa/main/enable.c
>> @@ -440,7 +440,7 @@ _mesa_set_enable(struct gl_context *ctx, GLenum cap, GLboolean state)
>>           ctx->Color.IndexLogicOpEnabled = state;
>>           break;
>>        case GL_CONSERVATIVE_RASTERIZATION_INTEL:
>> -         if (!_mesa_is_desktop_gl(ctx) && ctx->API != API_OPENGLES)
>> +         if (!_mesa_has_INTEL_conservative_rasterization(ctx))
>>              goto invalid_enum_error;
>>           if (ctx->IntelConservativeRasterization == state)
>>              return;
>> --
>> 2.10.2
>>


More information about the mesa-dev mailing list