[Mesa-dev] [PATCH 5/7] i965: Move pipelined register access to its own file

[Emil Velikov]

On 9 December 2016 at 10:54, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> --- /dev/null
> +++ b/src/mesa/drivers/dri/i965/brw_pipelined_register.h

> +#ifndef BRW_PIPELINED_REGISTER_H
> +#define BRW_PIPELINED_REGISTER_H
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +void brw_load_register_mem32(struct brw_context *brw,
> +                             uint32_t reg,
> +                             drm_intel_bo *bo,
> +                             uint32_t offset);
> +void brw_load_register_mem64(struct brw_context *brw,
> +                             uint32_t reg,
> +                             drm_intel_bo *bo,
> +                             uint32_t offset);
> +
Please add a couple of forward declarations/includes to resolve the
above types. It will save you/others a bit of "wtf" moments as one
reorders the header inclusions at a later stage.

Thanks
Emil