[Mesa-dev] [PATCH 05/10] nir: don't count removal of lcssa_phi as progress

Pohjolainen, Topi topi.pohjolainen at gmail.com
Sat Dec 10 12:18:30 UTC 2016


On Tue, Dec 06, 2016 at 12:12:23PM +1100, Timothy Arceri wrote:
> ---
>  src/compiler/nir/nir_opt_remove_phis.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c
> index acaa6e1..d4344b0 100644
> --- a/src/compiler/nir/nir_opt_remove_phis.c
> +++ b/src/compiler/nir/nir_opt_remove_phis.c
> @@ -73,6 +73,7 @@ remove_phis_block(nir_block *block, nir_builder *b)
>           break;
>  
>        nir_phi_instr *phi = nir_instr_as_phi(instr);
> +      bool is_lcssa_phi = phi->is_lcssa_phi;

Could be const.

>  
>        nir_ssa_def *def = NULL;
>        nir_alu_instr *mov = NULL;
> @@ -133,7 +134,8 @@ remove_phis_block(nir_block *block, nir_builder *b)
>        nir_ssa_def_rewrite_uses(&phi->dest.ssa, nir_src_for_ssa(def));
>        nir_instr_remove(instr);
>  
> -      progress = true;
> +      if (!is_lcssa_phi)
> +         progress = true;
>     }
>  
>     return progress;
> -- 
> 2.7.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list