[Mesa-dev] [PATCH v3] EGL/android: Enhance pbuffer implementation

Tomasz Figa tfiga at chromium.org
Mon Dec 12 05:03:17 UTC 2016


Hi,

On Fri, Dec 9, 2016 at 8:29 PM, Liu Zhiquan <zhiquan.liu at intel.com> wrote:
> Some dri drivers will pass multiple bits in buffer_mask parameter
> to droid_image_get_buffer(), more than the actual supported buffer
> type combination. For such case, will go through all the bits, and
> will not return error when unsupported buffer is requested, only
> return error when the allocation for supported buffer failed.
>
> v2: coding style and log changes
> v3: coding style changes and update patch format
>
> Signed-off-by: Liu Zhiquan <zhiquan.liu at intel.com>
> Signed-off-by: Long, Zhifang <zhifang.long at intel.com>
> Reviewed-by: Tomasz Figa <tfiga at chromium.org>
> ---
>  src/egl/drivers/dri2/platform_android.c | 177 +++++++++++++++++---------------
>  1 file changed, 96 insertions(+), 81 deletions(-)
>

Looks good, thanks for patiently addressing all the nitpicks. Re-affirming:

Reviewed-by: Tomasz Figa <tfiga at chromium.org>

Best regards,
Tomasz


More information about the mesa-dev mailing list