[Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

[Emil Velikov]

On 15 December 2016 at 01:10, Randy Xu <randy.xu at intel.com> wrote:
> From: "Xu,Randy" <randy.xu at intel.com>
>
> Refer to GLES3.2 spec in 8.5
> Textures with a base internal format of DEPTH_COMPONENT, DEPTH_-
> STENCIL or STENCIL_INDEX are supported by texture image specification
> commands only if target is TEXTURE_2D, TEXTURE_2D_MULTISAMPLE,
> TEXTURE_2D_ARRAY, TEXTURE_2D_MULTISAMPLE_ARRAY, TEXTURE_CUBE_-
> MAP or TEXTURE_CUBE_MAP_ARRAY. Using these formats in conjunction with
> any other target will result in an INVALID_OPERATION error.
> This patch can fix dEQP-GLES3.functional.negative_api.texture.teximage3d
> failure.
>
I think others have alluded it with referencing other commits, but it
might have been too subtle.
 - please use the cannonical format [1] to add a spec quote in the code
 - your commit message should explain why rather than a simple spec quote.
You can draw some inspirations from 19f13b2096a9fdd986e5a12d4e9d8b0d6a4632f3

> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=99076
>
Nit: s/Bug/Bugzilla/

Please also add the following so we get this in the stable release.
Cc: "13.0" <mesa-stable at lists.freedesktop.org>

Thanks
Emiol