[Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

[Nayan Deshmukh]

I send out the wrong series, the earlier one. I am sending the v2.

I am not sure of the reason as to why it was returning a bool anyways.
So I was hoping that someone could point out the reason.

Regards,
Nayan


On Thu, Dec 15, 2016 at 7:24 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Also, please at least *compile test* your patches. This patch doesn't compile.
>
> On Thu, Dec 15, 2016 at 8:54 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Should there be a patch 5 which makes vl_compositor_init_state return void?
>>
>> On Thu, Dec 15, 2016 at 8:34 AM, Nayan Deshmukh
>> <nayan26deshmukh at gmail.com> wrote:
>>> vl_compositor_init_state always return true so we don't
>>> need to handle false case
>>>
>>> Signed-off-by: Nayan Deshmukh <nayan26deshmukh at gmail.com>
>>> ---
>>>  src/gallium/state_trackers/xvmc/context.c | 8 +-------
>>>  1 file changed, 1 insertion(+), 7 deletions(-)
>>>
>>> diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/gallium/state_trackers/xvmc/context.c
>>> index 469e1c1..4ae7d7b 100644
>>> --- a/src/gallium/state_trackers/xvmc/context.c
>>> +++ b/src/gallium/state_trackers/xvmc/context.c
>>> @@ -262,11 +262,7 @@ Status XvMCCreateContext(Display *dpy, XvPortID port, int surface_type_id,
>>>        goto no_compositor;
>>>     }
>>>
>>> -   if (!vl_compositor_init_state(&context_priv->cstate, pipe)) {
>>> -      XVMC_MSG(XVMC_ERR, "[XvMC] Could not create VL compositor state.\n");
>>> -      goto no_compositor_state;
>>> -   }
>>> -
>>> +   vl_compositor_init_state(&context_priv->cstate, pipe)
>>>
>>>     context_priv->color_standard =
>>>        debug_get_bool_option("G3DVL_NO_CSC", FALSE) ?
>>> @@ -299,8 +295,6 @@ Status XvMCCreateContext(Display *dpy, XvPortID port, int surface_type_id,
>>>
>>>     return Success;
>>>
>>> -no_compositor_state:
>>> -   vl_compositor_cleanup(&context_priv->compositor);
>>>  no_compositor:
>>>     context_priv->decoder->destroy(context_priv->decoder);
>>>  no_decoder:
>>> --
>>> 2.9.3
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev