[Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

Nayan Deshmukh nayan26deshmukh at gmail.com
Thu Dec 15 14:18:42 UTC 2016


My apologies for sending the wrong series.



On Thu, Dec 15, 2016 at 7:45 PM, Christian K├Ânig
<deathsimple at vodafone.de> wrote:
> Am 15.12.2016 um 15:07 schrieb Emil Velikov:
>>
>> On 15 December 2016 at 13:57, Nayan Deshmukh <nayan26deshmukh at gmail.com>
>> wrote:
>>>
>>> I send out the wrong series, the earlier one. I am sending the v2.
>>>
>>> I am not sure of the reason as to why it was returning a bool anyways.
>>> So I was hoping that someone could point out the reason.
>>>
>> Looking within... strictly speaking pipe_buffer_create() and
>> vl_compositor_set_csc_matrix() can fail.
>> Christian seems to be the author back in 2012, so not sure if he still
>> recalls the details.
>
>
> My best guess is that the function used to have error handling or at least
> should have error handling, but this was never properly implemented.
>
> If you want to clean this up I suggest to either follow Ilia's comment as
> well and make the function return void, or go into the other direction and
> implement proper error handling (preferred).
>
I will send in a patch with error handling.

Regards,
Nayan
> Regards,
> Christian.
>
>>
>> Emil
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
>


More information about the mesa-dev mailing list