[Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

[Thierry Reding]

On Thu, Dec 01, 2016 at 03:00:20PM +0000, Emil Velikov wrote:
> On 30 November 2016 at 13:44, Christian Gmeiner
> <christian.gmeiner at gmail.com> wrote:
> > The imx (stub) driver is needed to get hardware acceleration from
> > etnaviv on a platform using imx-drm kms driver. This adds support
> > for wayland and native kms egl apps.
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> > ---
> >  configure.ac                                       | 12 +++++++
> >  src/gallium/Makefile.am                            |  4 +++
> >  .../auxiliary/pipe-loader/pipe_loader_drm.c        |  5 +++
> >  src/gallium/auxiliary/target-helpers/drm_helper.h  | 23 ++++++++++++
> >  .../auxiliary/target-helpers/drm_helper_public.h   |  3 ++
> >  src/gallium/drivers/imx/Automake.inc               |  9 +++++
> >  src/gallium/drivers/imx/Makefile.am                |  9 +++++
> >  src/gallium/winsys/imx/drm/Makefile.am             | 33 +++++++++++++++++
> >  src/gallium/winsys/imx/drm/Makefile.sources        |  3 ++
> >  src/gallium/winsys/imx/drm/imx_drm_public.h        | 31 ++++++++++++++++
> >  src/gallium/winsys/imx/drm/imx_drm_winsys.c        | 41 ++++++++++++++++++++++
> >  11 files changed, 173 insertions(+)
> I think you want to add the following to src/gallium/targets/dri/Makefile.am
> 
> include $(top_srcdir)/src/gallium/drivers/imx/Automake.inc
> 
> Otherwise there will be no imx_dri.so module which you can use.
> ^^ is a must have afaics, everything else (mentioned below) can be
> tackled at a later stage.
> 
> A set of targets/pipe-loader/* changes would be nice... unless I beat
> you to it and fold the final round of duplication that we have in the
> pipe-loader/targets topic ;-)
> 
> 
> > +include Makefile.sources
> > +include $(top_srcdir)/src/gallium/Automake.inc
> > +
> > +AM_CFLAGS = \
> > +       -I$(top_srcdir)/src/gallium/drivers \
> Add the following and then ...
>        -I$(top_srcdir)/src/gallium/winsys \
> 
> > +       $(GALLIUM_WINSYS_CFLAGS) \
> > +       $(IMX_CFLAGS)
> > +
> > +noinst_LTLIBRARIES = libimxdrm.la
> > +
> > +libimxdrm_la_SOURCES = $(C_SOURCES)
> > \ No newline at end of file
> Please add the missing newlines throughout.
> 
> 
> > diff --git a/src/gallium/winsys/imx/drm/imx_drm_public.h b/src/gallium/winsys/imx/drm/imx_drm_public.h
> > new file mode 100644
> > index 0000000..2d93da2
> > --- /dev/null
> > +++ b/src/gallium/winsys/imx/drm/imx_drm_public.h
> > @@ -0,0 +1,31 @@
> > +/*
> > + * Copyright © 2014 NVIDIA Corporation
> > + *
> Disclaimer: IANAL
> 
> Here and other copyright notices could be updated to reflect you.
> Things have changed noticeably that any recemblense with the original
> is conicidential.

Agreed, there's nothing in this file that I'd consider copyright of
NVIDIA. If there's anything copyrightable in this series at all I'd
think it'd be the create/export/import/tiling dance that the render-
only library does.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161219/da00e1ca/attachment.sig>