[Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

[Samuel Iglesias Gonsálvez]

On Mon, 2016-12-19 at 11:31 -0600, Matt Turner wrote:
> On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez
> <siglesias at igalia.com> wrote:
> > Hello Matt,
> > 
> > We have done most of the suggestions you made to our patches.
> > However,
> > we have replied to some of your questions/suggestions and we are
> > waiting for a reply before marking them as R-b or not.
> 
> Thank you guys so much.
> 
> > You can clone the new version of the patch series by running this
> > command:
> > 
> > $ git clone -b i965-fp64-gen7-scalar-vec4-rc3 https://github.com/Ig
> > alia
> > /mesa.git
> > 
> > Below is the list of patches that need a R-b (they are marked as
> > UNREVIEWED in the branch).
> > 
> > * i965/vec4: implement hardware workaround for align16 double to
> > float
> > conversion
> > > 
> > >       This always seemed like a really strange hardware bug, and
> > 
> > one
> > >       that no one should ever hit.
> > > 
> > >       I'd prefer that, instead of loading an immediate double and
> > > then
> > >       performing a conversion to float, that we just convert the
> > >       double to float in the compiler and emit an instruction to
> > 
> > load
> > >       that.
> > > 
> > 
> >   We have done this. Does this change get your R-b?
> 
> Yes!
> 
> > 
> > * i965/vec4: fix optimize predicate for doubles
> > 
> >   We have replied here [0].
> 
> Sounds good to me.
> 
> > 
> > * i965/vec4: handle 32 and 64 bit channels in liveness analysis
> > 
> >   It is still unreviewed. Maybe Curro can take a look at it.
> 
> I've also pinged Curro to ask if he'll review it.
> 
> > * i965/vec4: add a SIMD lowering pass
> > 
> >   Replied here [1].
> 
> Silly messy hardware. :)
> 
> > * i965/vec4: Prevent copy propagation from violating pre-gen8
> > restrictions
> > 
> >   Replied here [1].
> > 
> > * i965/vec4: run scalarize_df() after spilling
> > 
> >   Replied here [1].
> 
> Makes sense.
> 
> Yes, all of those should be
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
> Again, thank you so much. This was a large amount of work, and the
> way
> you guys handled it was extremely impressive. I'm only sorry that the
> review of your work wasn't executed as well as your actual work!
> 

Thanks to you for the review! :-)

Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161220/3ad5cbf9/attachment.sig>