[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

Eero Tamminen eero.t.tamminen at intel.com
Tue Dec 20 10:56:16 UTC 2016


Hi,

I think it fixed one of the segfaults with closed vkreplay window, but 
it still segfaults. For details, see backtrace here:
	https://github.com/LunarG/VulkanTools/issues/124

	- Eero

On 20.12.2016 05:59, Arda Coskunses wrote:
> Without this check driver crash when application window
> closed unexpectedly.
> ---
>  src/vulkan/wsi/wsi_common_x11.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
> index 25ba0c1..afb7809 100644
> --- a/src/vulkan/wsi/wsi_common_x11.c
> +++ b/src/vulkan/wsi/wsi_common_x11.c
> @@ -261,6 +261,11 @@ VkBool32 wsi_get_physical_device_xcb_presentation_support(
>     struct wsi_x11_connection *wsi_conn =
>        wsi_x11_get_connection(wsi_device, alloc, connection);
>
> +   if (!wsi_conn) {
> +      fprintf(stderr, "vulkan: wsi connection lost\n");
> +      return false;
> +   }
> +
>     if (!wsi_conn->has_dri3) {
>        fprintf(stderr, "vulkan: No DRI3 support\n");
>        return false;
>



More information about the mesa-dev mailing list