[Mesa-dev] [PATCH] loader: Add vim modeline

Ilia Mirkin imirkin at alum.mit.edu
Wed Dec 21 14:27:12 UTC 2016


On Wed, Dec 21, 2016 at 9:15 AM, Thierry Reding
<thierry.reding at gmail.com> wrote:
> On Wed, Dec 21, 2016 at 08:49:18AM -0500, Ilia Mirkin wrote:
>> So you want every file to have a modeline for every editor? Is there no way
>> to do this at the directory level, like you can with emacs? I thought there
>> was some editorconfig thing...
>
> I'm sure there are ways to do that, I was merely following what was
> already being done in other files.
>
> And yes, this isn't optimal, but neither is having each author add their
> own indentation style to the files.
>
> Solutions that I've found that do this per directory aren't very optimal
> either because you'd still need one file per editor and per directory,
> and they all require manual intervention to activate. Most are insecure
> to the point where I wouldn't want to enable them.

Can you have a look at http://editorconfig.org/ ? We already have a
.editorconfig at the top level, and in other places which need
different settings.

There's a vim modeline in a total of 17 files in mesa, mostly in
st/dri. All but a handful configure settings that should be the
defaults for the whole mesa tree anyways.

I'd rather avoid additional proliferation of these. To be clear, mesa
style is: no tabs (tab char = 8 spaces), indent by 3. This is used in
most of the repo, but not all - some drivers, e.g. radeon,
nouveau_vieux, a few others use tabs instead of spaces. freedreno uses
tabs with a tab width of 4. Probably a few other oddballs.

  -ilia


More information about the mesa-dev mailing list