[Mesa-dev] [PATCH] radv/image: only touch queue family info for concurrent images.

Edward O'Callaghan funfunctor at folklore1984.net
Wed Dec 21 23:32:00 UTC 2016


Acked-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 12/22/2016 10:30 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> The spec says to ignore these fields for exclusive images.
> 
> Fixes crashes in:
> dEQP-VK.clipping.*
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_image.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index fee4f14..8a01ea8 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -700,8 +700,10 @@ radv_image_create(VkDevice _device,
>  	image->usage = pCreateInfo->usage;
>  
>  	image->exclusive = pCreateInfo->sharingMode == VK_SHARING_MODE_EXCLUSIVE;
> -	for (uint32_t i = 0; i < pCreateInfo->queueFamilyIndexCount; ++i)
> -		image->queue_family_mask |= 1u << pCreateInfo->pQueueFamilyIndices[i];
> +	if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
> +		for (uint32_t i = 0; i < pCreateInfo->queueFamilyIndexCount; ++i)
> +			image->queue_family_mask |= 1u << pCreateInfo->pQueueFamilyIndices[i];
> +	}
>  
>  	radv_init_surface(device, &image->surface, create_info);
>  
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161222/c20873c8/attachment.sig>


More information about the mesa-dev mailing list