[Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

[Samuel Iglesias Gonsálvez]

On Thu, 2016-12-22 at 12:13 -0600, Matt Turner wrote:
> On Tue, Dec 13, 2016 at 2:01 AM, Samuel Iglesias Gonsálvez
> <siglesias at igalia.com> wrote:
> > On Mon, 2016-12-05 at 15:21 -0800, Matt Turner wrote:
> > > i965/vec4: add a helper function to create double immediates
> > > 
> > >       Can leave for later: Shouldn't we use the DIM instruction
> > > (on
> > >       HSW)?
> > > 
> > >       I'm not sure if this should be fixed now or later, but
> > > shouldn't
> > >       we use NibCtrl on these two instructions instead of
> > >       force_writemask_all? I think this is a case where NibCtrl
> > > is
> > >       useful.
> > > 
> > 
> > Yes, we can use DIM instruction here. We are going to write a
> > follow-up
> > patch for it.
> 
> I noticed a bug in "i965/fs: emit DIM instruction to load 64-bit
> immediates in HSW"
> 
> You want
> 
> -      const fs_builder ubld = bld.exec_all();
> +      const fs_builder ubld = bld.exec_all().group(1, 0);
> 
> otherwise, DIM instructions will be emitted with the default exec
> size
> -- dim(16) in some cases, which is not legal.
> 

Oh, good catch. I am going to write the patch.

Thanks!

Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161223/28ea894f/attachment.sig>