[Mesa-dev] [PATCH 1/3] gallium: add renderonly library

[Emil Velikov]

On 19 December 2016 at 21:50, Thierry Reding <thierry.reding at gmail.com> wrote:
> On Mon, Dec 19, 2016 at 08:54:04PM +0100, Christian Gmeiner wrote:
>> 2016-12-19 14:08 GMT+01:00 Thierry Reding <thierry.reding at gmail.com>:
>> > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote:
> [...]
>> >>  GALLIUM_WINSYS_CFLAGS = \
>> >>       -I$(top_srcdir)/src \
>> >>       -I$(top_srcdir)/include \
>> >> diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am
>> >> index 4a4a4fb..6b63cf1 100644
>> >> --- a/src/gallium/auxiliary/Makefile.am
>> >> +++ b/src/gallium/auxiliary/Makefile.am
>> >> @@ -20,6 +20,16 @@ libgallium_la_SOURCES = \
>> >>       $(NIR_SOURCES) \
>> >>       $(GENERATED_SOURCES)
>> >>
>> >> +if HAVE_LIBDRM
>> >> +
>> >> +AM_CFLAGS += \
>> >> +     $(LIBDRM_CFLAGS)
>> >
>> > Same here.
>>
>> I just redone what other have done in that file. There are some if's
>> in that file and I am unsure
>> what to do here.
>
> Maybe Emil has a strong opinion here, I was really just nit-picking, so
> feel free to leave this.
>
There's no strong policy for these, plus we have a mix of the two atm.
I'm fine either way on the include/cflags, but if anyone has strong
preference sure go ahead :-)

Emil