[Mesa-dev] [PATCH 0/8] nir: A few allocation cleanups

Eduardo Lima Mitev elima at igalia.com
Tue Dec 27 13:07:22 UTC 2016


On 12/26/2016 06:13 PM, Jason Ekstrand wrote:
> The first patch in this series is a change I've been meaning to make for
> some time.  I've been running into name collisions with nir_copy_deref and
> the nir_builder nir_copy_deref_var helper.  Also, now that we have lots of
> other "clone" stuff, it makes sense to make things make them all match.
> 
> The other 7 patches are fixes that update some passes a bit and make us
> handle ralloc memory contexts better.
> 

Patches 2 to 7 are

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

Thanks!

> Jason Ekstrand (8):
>   nir: Make nir_copy_deref follow the "clone" pattern
>   nir/from_ssa: Use nir_builder for emit_copy
>   nir/lower_io: Use the builder instead of carrying a mem_ctx
>   nir/lower_var_copies: Use a shader rather than a void *mem_ctx
>   nir/conditional_if: Properly use the builder
>   nir/opt_peephole_select: Pass around the actual nir_shader
>   nir/split_var_copies: Use a nir_shader rather than a void *mem_ctx
>   i965/peephole_ffma: Use nir_builder
> 
>  src/compiler/glsl/glsl_to_nir.cpp                  |  3 +-
>  src/compiler/nir/nir.c                             | 22 +++++------
>  src/compiler/nir/nir.h                             |  6 +--
>  src/compiler/nir/nir_builder.h                     |  6 +--
>  src/compiler/nir/nir_from_ssa.c                    | 26 ++++++-------
>  src/compiler/nir/nir_inline_functions.c            |  2 +-
>  src/compiler/nir/nir_lower_indirect_derefs.c       |  6 +--
>  src/compiler/nir/nir_lower_io.c                    | 16 ++++----
>  src/compiler/nir/nir_lower_tex.c                   | 18 +++------
>  src/compiler/nir/nir_lower_var_copies.c            | 21 ++++++-----
>  src/compiler/nir/nir_opt_conditional_discard.c     | 21 +++++------
>  src/compiler/nir/nir_opt_peephole_select.c         |  9 +++--
>  src/compiler/nir/nir_split_var_copies.c            | 23 +++++-------
>  src/compiler/spirv/spirv_to_nir.c                  | 22 +++++------
>  src/compiler/spirv/vtn_glsl450.c                   |  3 +-
>  src/compiler/spirv/vtn_variables.c                 |  3 +-
>  src/intel/vulkan/anv_nir_lower_input_attachments.c |  3 +-
>  .../drivers/dri/i965/brw_nir_opt_peephole_ffma.c   | 43 +++++++---------------
>  18 files changed, 111 insertions(+), 142 deletions(-)
> 



More information about the mesa-dev mailing list