[Mesa-dev] [PATCH] Fix locking of GLsync objects

[Steinar H. Gunderson]

On Mon, Feb 01, 2016 at 04:00:09PM +0100, Marek Olšák wrote:
> Sorry, I'm withdrawing my statement.
> 
> Look at this code:
> 
>  _mesa_ObjectPtrLabel(const void *ptr, GLsizei length, const GLchar *label)
>  {
>     GET_CURRENT_CONTEXT(ctx);
> -   struct gl_sync_object *const syncObj = (struct gl_sync_object *) ptr;
> +   struct gl_sync_object *syncObj = _mesa_get_and_ref_sync(ctx, sync, true);
> 
> "sync" is undeclared here. It builds, because "sync" is also a
> function from unistd.h. This is wrong.

You're right -- that's a nice catch. It ought to be “ptr”, of course, not
“sync”.

/* Steinar */
-- 
Homepage: https://www.sesse.net/