[Mesa-dev] [PATCH v2 5/9] mesa/st: Update framebuffer state with no.of samples, layers

[Ilia Mirkin]

On Fri, Feb 5, 2016 at 6:44 AM, Edward O'Callaghan
<eocallaghan at alterapraxis.com> wrote:
> Handle the case of ARB_framebuffer_no_attachment.
> Also, kill off a dead debug printf() call while we are here.
>
> Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

You did the full piglit run like I asked before sticking my R-b on
here? (Why the "at" vs "@"? That's not how I typed it...)

Separately, you need something like this either in this commit or
elsewhere in the series:

http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb9cf3cfc99db0cff0a5a584941e8be43ac9b961

(this was just added.) Haven't thought about where it is proper to add
this in st/mesa.

> ---
>  src/mesa/state_tracker/st_atom_framebuffer.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa/state_tracker/st_atom_framebuffer.c
> index ae883a2..671ef07 100644
> --- a/src/mesa/state_tracker/st_atom_framebuffer.c
> +++ b/src/mesa/state_tracker/st_atom_framebuffer.c
> @@ -43,6 +43,7 @@
>  #include "util/u_math.h"
>  #include "util/u_inlines.h"
>  #include "util/u_format.h"
> +#include "main/framebuffer.h"
>
>
>  /**
> @@ -79,10 +80,11 @@ update_framebuffer_state( struct st_context *st )
>     st_flush_bitmap_cache(st);
>
>     st->state.fb_orientation = st_fb_orientation(fb);
> -   framebuffer->width  = UINT_MAX;
> -   framebuffer->height = UINT_MAX;
>
> -   /*printf("------ fb size %d x %d\n", fb->Width, fb->Height);*/
> +   framebuffer->width  = _mesa_geometric_width(fb);
> +   framebuffer->height = _mesa_geometric_height(fb);
> +   framebuffer->samples = _mesa_geometric_samples(fb);
> +   framebuffer->layers = _mesa_geometric_layers(fb);
>
>     /* Examine Mesa's ctx->DrawBuffer->_ColorDrawBuffers state
>      * to determine which surfaces to draw to
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev