[Mesa-dev] [Mesa-stable] [PATCH v3] glx: update to updated version of EXT_create_context_es2_profile

Ian Romanick idr at freedesktop.org
Fri Feb 5 20:10:01 UTC 2016


On 02/04/2016 07:54 AM, Ilia Mirkin wrote:
> On Thu, Feb 4, 2016 at 10:50 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi Ilia,
>>
>> On 3 February 2016 at 14:52, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> The EXT spec has been updated to:
>>>  - logically combine the es2_profile and es_profile exts
>>>  - allow any legal version to be requested
>>>
>>> dEQP tests request a specific ES version when using GLX, so this allows
>>> dEQP upstream to run against GLX with the appropriate X server patch
>>> (which had similar disabling logic).
>>>
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>> Reviewed-by: Matt Turner <mattst88 at gmail.com> (v1)
>>>
>>> v1 -> v2:
>>>  - distinguish between DRI_API_GLES{,2,3}
>>>  - add GLX_EXT_create_context_es_profile client-side support
>>> v2 -> v3:
>>>  - fix error in computing mask
>>> ---
>>>  src/glx/dri2_glx.c      | 11 ++++++++---
>>>  src/glx/dri3_glx.c      |  7 ++++++-
>>>  src/glx/dri_common.c    | 28 ++++++++++++----------------
>>>  src/glx/drisw_glx.c     |  4 +++-
>>>  src/glx/glxextensions.c |  1 +
>>>  src/glx/glxextensions.h |  1 +
>>>  6 files changed, 31 insertions(+), 21 deletions(-)
>>>
>> Any objections if we pull this for mesa-stable ?
> 
> None from me, but it seems to overstep the mark of backports. If
> you're comfortable with it, go for it. Do note that it requires a
> patched X server in order to have any effect. The X server patch
> appears to be targeted for 1.18 backport, but not sure if there will
> be another 1.17 release (or whether that patch would be included
> there).

I think it should be fine for 11.1.  We're deviating from the spec, and
that causes at least one application to fail.  The X server dependency
makes it a little bit moot, but *shrug*.

>   -ilia
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable



More information about the mesa-dev mailing list