[Mesa-dev] [PATCH 1/2] glsl: replace unreachable code with an assert()

Kenneth Graunke kenneth at whitecape.org
Sat Feb 6 03:13:45 UTC 2016


On Wednesday, February 3, 2016 10:26:07 AM PST Timothy Arceri wrote:
> All interface blocks will have been lowered by this point so just
> use an assert. Returning false would have caused all sorts of
> problems if they were not lowered yet and there is an assert to
> catch this later anyway.
> 
> We also update the tests to reflect this change.
> ---
>  src/compiler/glsl/link_varyings.cpp       | 25 ++++------
>  src/compiler/glsl/tests/varyings_test.cpp | 78
> ++++++++++++------------------- 2 files changed, 38 insertions(+), 65
> deletions(-)

Both are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20160205/38e7dc5f/attachment.sig>


More information about the mesa-dev mailing list