[Mesa-dev] [PATCH 11/23] i965/gen8: Remove dead assertion

Topi Pohjolainen topi.pohjolainen at intel.com
Mon Feb 8 16:51:31 UTC 2016


The assertion is inside a condition mandating num_samples > 1 and
therefore the first half of the constraint is always met. The
second half in turn would only be applicable for single sampled
case and moreover it is trying to falsely check against surface
type instead of format.
Subsequent patches will introduce proper support for the lossless
compression and dropping this here makes the patches a little
simpler.

Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
---
 src/mesa/drivers/dri/i965/gen8_surface_state.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c
index 0df25d2..fc8f701 100644
--- a/src/mesa/drivers/dri/i965/gen8_surface_state.c
+++ b/src/mesa/drivers/dri/i965/gen8_surface_state.c
@@ -243,12 +243,6 @@ gen8_emit_texture_surface_state(struct brw_context *brw,
        */
       if (brw->gen >= 9 || mt->num_samples == 1)
          assert(mt->halign == 16);
-
-      if (brw->gen >= 9) {
-         assert(mt->num_samples > 1 ||
-                brw_losslessly_compressible_format(brw, surf_type));
-      }
-
    }
 
    uint32_t *surf = allocate_surface_state(brw, surf_offset, surf_index);
-- 
2.5.0



More information about the mesa-dev mailing list