[Mesa-dev] [PATCH 2/5] st/mesa: handle indirect samplers in arrays/structs properly (v4)

[Dave Airlie]

>> +
>> +   assert(var);
>> +   location = var->data.location;
>> +   calc_deref_offsets(ir, ir, array_size, base, index, reladdr,
>> &location);
>> +
>> +   if (location != 0xffffffff) {
>
> This could just be an assert right? It shouldn't ever be -1 for a
> sampler unless something went wrong in the linker.

atomics trigger this. so I pulled it into this patch.

>
> As I said last time I don't really understand all this tgsi specifics
> (which is around half the patch) but this time round the offset
> calculation looks correct so for what its worth this patch, 3 and 5 are
>
> Reviewed-by: Timothy Arcer <timothy.arceri at collabora.com>

Thanks,
Dave.