[Mesa-dev] [PATCH] nir: remove unused nir_variable fields

[Kenneth Graunke]

On Tuesday, February 2, 2016 11:53:57 AM PST Timothy Arceri wrote:
> These are used in GLSL IR to removed unused varyings and match
> transform feedback variables. There is no need to use these in NIR.
> ---
>  src/compiler/nir/glsl_to_nir.cpp |  2 --
>  src/compiler/nir/nir.h           | 18 ------------------
>  2 files changed, 20 deletions(-)
> 
> diff --git a/src/compiler/nir/glsl_to_nir.cpp b/src/compiler/nir/glsl_to_nir.cpp
> index 4b76d23..b9e27e9 100644
> --- a/src/compiler/nir/glsl_to_nir.cpp
> +++ b/src/compiler/nir/glsl_to_nir.cpp
> @@ -364,8 +364,6 @@ nir_visitor::visit(ir_variable *ir)
>     var->data.explicit_binding = ir->data.explicit_binding;
>     var->data.has_initializer = ir->data.has_initializer;
>     var->data.location_frac = ir->data.location_frac;
> -   var->data.from_named_ifc_block_array = ir->data.from_named_ifc_block_array;
> -   var->data.from_named_ifc_block_nonarray = ir->data.from_named_ifc_block_nonarray;
>  
>     switch (ir->data.depth_layout) {
>     case ir_depth_layout_none:
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index aec75fb..3fc87ae 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -224,24 +224,6 @@ typedef struct nir_variable {
>        unsigned location_frac:2;
>  
>        /**
> -       * Non-zero if this variable was created by lowering a named interface
> -       * block which was not an array.
> -       *
> -       * Note that this variable and \c from_named_ifc_block_array will never
> -       * both be non-zero.
> -       */
> -      unsigned from_named_ifc_block_nonarray:1;
> -
> -      /**
> -       * Non-zero if this variable was created by lowering a named interface
> -       * block which was an array.
> -       *
> -       * Note that this variable and \c from_named_ifc_block_nonarray will never
> -       * both be non-zero.
> -       */
> -      unsigned from_named_ifc_block_array:1;
> -
> -      /**
>         * \brief Layout qualifier for gl_FragDepth.
>         *
>         * This is not equal to \c ir_depth_layout_none if and only if this
> 


Yep, it doesn't make much sense to have these post-linking.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160209/7cfb51a1/attachment.sig>