[Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

Ian Romanick idr at freedesktop.org
Tue Feb 9 16:57:02 UTC 2016


Patches 1, 2, and 4 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Pending the result of the Khronos spec bug, patch 3 is also R-b.

On 01/12/2016 01:34 AM, Timothy Arceri wrote:
> I don't think this will do much as it's a compiler error
> to use component without location which is already in the
> table but its good to be consistent.
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index 7330a34..6d6f88f 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -73,6 +73,7 @@ ast_type_qualifier::has_layout() const
>            || this->flags.q.column_major
>            || this->flags.q.row_major
>            || this->flags.q.packed
> +          || this->flags.q.explicit_component
>            || this->flags.q.explicit_location
>            || this->flags.q.explicit_index
>            || this->flags.q.explicit_binding
> 



More information about the mesa-dev mailing list