[Mesa-dev] [PATCH 4/4] i965: Make brw_clear_cache flag all the bits on both pipelines.

[Ilia Mirkin]

On Tue, Feb 9, 2016 at 7:49 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Setting brw->ctx.NewDriverState and brw->ctx.NewGLState affects
> the dirty bits for the current pipeline.  But, we need to flag
> everything dirty on *both* pipelines, so that when we switch
> back, we'll realize our programs are stale and re-upload them.
>
> To accomplish this, flag the saved state for both pipelines.
> Only one of them should matter, but this way we don't have to
> check which we need to set.  It's harmless to set the other.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93790
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

I can confirm that with this patch series, the crashes and valgrind
use-after-free errors when running
bin/arb_shader_image_load_store-semantics are gone on HSW.

I'll go back to running dEQP, which I suspect will run into other
crashes (it always seems to).

Thanks for investigating! Feel free to add my

Tested-by: Ilia Mirkin <imirkin at alum.mit.edu>

  -ilia