[Mesa-dev] building with -Wshadow

[Ian Romanick]

On 02/10/2016 10:48 AM, Ian Romanick wrote:
> On 02/09/2016 08:43 PM, Dave Airlie wrote:
>> I was just messing with warning flags on virglrenderer and noticed
>> -Wshadow generated a fair few warnings with gallium, so I did a mesa
>> build with -Wshadow enabled and it was fairly messy,
>>
>> do we care? there could be bugs hiding in -Wshadow land.
> 
> I have mixed feelings about -Wshadow.  In principle, it's a good warning
> to use, and it can catch real bugs.  However, thanks to standard library
> functions with jackass names like "index", the signal-to-noise ratio
> chases even me away. :(

Though acording to the link Emil sent, GCC 4.8 may have fixed this.  Yay!

> I'm more than happy to review patches that fix -Wshadow issues, but,
> unless the noise of old has been solved, I probably won't build with it
> on a regular basis.
> 
>> Dave.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev