[Mesa-dev] [RFC] vc4: Remove logically dead variable 'handled_qinst_cond'

Eric Anholt eric at anholt.net
Fri Feb 12 06:27:27 UTC 2016


Rhys Kidd <rhyskidd at gmail.com> writes:

> Variable no longer is read, and always set to true.
>
> Accordingly, the later assert() serves no active current purpose. The prior
> limb of the test 'qinst->cond == QPU_COND_ALWAYS' will never trigger an assert()
> as is. If it did previously define a relevant test, this should be revisited
> in a subsequent patch.

Looks like just a typo, was supposed to be set to false at the top.
Only the default case handles a cond on the qinst so far, so we want to
be sure that we didn't try to put a cond on any other type of qinst.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160211/0ebabeb0/attachment.sig>


More information about the mesa-dev mailing list