[Mesa-dev] [PATCH] mesa: reset offset/size to 0 when removing atomic binding

[Brian Paul]

On 02/12/2016 11:51 AM, Ilia Mirkin wrote:
> Similar to commit dd9d2963d6 (mesa: AtomicBufferBindings should be
> initialized to zero.), we should reset these to zero when unbinding.
> This fixes a number of dEQP failures due to cross-test pollution. The
> tests properly unbound everything, but when querying the values again,
> the expectation was that they would be 0.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   src/mesa/main/bufferobj.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index de1aba4..9aec425 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -3007,8 +3007,8 @@ set_atomic_buffer_binding(struct gl_context *ctx,
>      _mesa_reference_buffer_object(ctx, &binding->BufferObject, bufObj);
>
>      if (bufObj == ctx->Shared->NullBufferObj) {
> -      binding->Offset = -1;
> -      binding->Size = -1;
> +      binding->Offset = 0;
> +      binding->Size = 0;
>      } else {
>         binding->Offset = offset;
>         binding->Size = size;
>

Looks OK to me.

Reviewed-by: Brian Paul <brianp at vmware.com>