[Mesa-dev] [PATCH 00/12] Some more Nine fixes

[Axel Davy]

On 09/02/2016 14:58, Emil Velikov wrote:
> On 7 February 2016 at 23:13, Axel Davy <axel.davy at ens.fr> wrote:
>> A few more patches I'd like to get in 11.2.
>>
>> There a few cleanup patches and some fixes.
>>
>> The last patch fixes build with llvm 32 bits
>> when it isn't built with -mstackrealign.
>> Basically Apps have a 4 byte aligned stack,
>> and it needs to be converted at some point
>> to 16 byte aligned stack to have SSE code
>> and llvm work correctly. I think the better
>> is to just realign at d3d entry points.
>>
>> Any suggestion whether that last patch should
>> be sent to mesa stable or not ?
>>
> As is the patch is a bit large, I'm thinking if it wouldn't be better
> to get it in if we get (m)any reports ?
> Although I won't object if you/others want to squeeze it in.
>
>
>>    st/nine: Align stack for entry points
>>
> As mentioned on IRC, one can just add the alignment to the definition
> of WINAP in d3dtypes.h. Other, non nine, users of the macro, should
> not include d3dtypes.h so we ought to be fine. Alternatively ...
But then I would have to duplicate the code to define PIPE_ALIGN_STACK.
I'd better not have to maintain compiler detection code.
>
>
>>   create mode 100644 src/gallium/state_trackers/nine/nine_alignment.h
>>
> Please add this new file to the list in
> src/gallium/state_trackers/nine/Makefile.sources
Sure. I will also rename to nine_flags, because we may put other things 
not related to alignment in it.

> Thanks
> Emil
>
And thanks to you !

Axel