[Mesa-dev] [PATCH] configure.ac: enable_asm=yes when x-compiling across same X86 arch

Matt Turner mattst88 at gmail.com
Sat Feb 13 01:11:12 UTC 2016


On Fri, Feb 12, 2016 at 5:04 PM, Dongwon Kim <dongwon.kim at intel.com> wrote:
> Currently, configure script is forcing 'enable_asm' to be 'no'
> whenever cross-compilation is performed on X86 host. This is
> based on an assumption that target architecture is different
> from host's (i.e. ARM). But there's always a case that we do
> cross-compile for target that is also X86 based just like host
> in which same ASM codes will be supported. In other words,
> 'enable_asm' should not be forced to be "no" anymore in this
> case.
>
> This change removes this limitation by reseting enable_asm
> if the host is one of X86 based architectures and target
> has exactly same architecture with it in cross-compilation
> environment.
>
> Signed-off-by: Dongwon Kim <dongwon.kim at intel.com>
> ---
>  configure.ac | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index b05f33d..0ad27c9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -710,8 +710,10 @@ test "x$enable_asm" = xno && AC_MSG_RESULT([no])
>  if test "x$enable_asm" = xyes -a "x$cross_compiling" = xyes; then
>      case "$host_cpu" in
>      i?86 | x86_64 | amd64)
> -        enable_asm=no
> -        AC_MSG_RESULT([no, cross compiling])
> +        if test "x$host_cpu" != "x$target_cpu"; then
> +            enable_asm=no
> +            AC_MSG_RESULT([no, cross compiling])
> +        fi
>          ;;

Seems like a good idea to me.

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list